Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field length validator ltr 2 #277

Merged

Conversation

landonreed
Copy link
Contributor

Refactor #276 a bit.

Copy link
Contributor

@evansiroky evansiroky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has merge conflicts.

@evansiroky evansiroky assigned landonreed and unassigned evansiroky Apr 3, 2020
@evansiroky evansiroky mentioned this pull request Apr 3, 2020
3 tasks
@binh-dam-ibigroup binh-dam-ibigroup merged commit fd249da into field-length-validator Apr 3, 2020
@codecov-io
Copy link

Codecov Report

Merging #277 into field-length-validator will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@                     Coverage Diff                      @@
##             field-length-validator     #277      +/-   ##
============================================================
+ Coverage                     65.28%   65.31%   +0.02%     
+ Complexity                      880      879       -1     
============================================================
  Files                           135      135              
  Lines                          6750     6743       -7     
  Branches                        795      795              
============================================================
- Hits                           4407     4404       -3     
+ Misses                         2044     2039       -5     
- Partials                        299      300       +1
Impacted Files Coverage Δ Complexity Δ
...conveyal/gtfs/validator/ReversedTripValidator.java 8.77% <ø> (+0.43%) 3 <0> (ø) ⬇️
src/main/java/com/conveyal/gtfs/loader/Feed.java 75.86% <100%> (+0.05%) 8 <0> (ø) ⬇️
src/main/java/com/conveyal/gtfs/GTFS.java 55.55% <100%> (ø) 12 <0> (-1) ⬇️
src/main/java/com/conveyal/gtfs/PatternFinder.java 85.22% <0%> (ø) 20% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b94a0e...fd249da. Read the comment docs.

@landonreed
Copy link
Contributor Author

🎉 This PR is included in version 6.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants